Add xpack.cloud.full_story configuration #102363
Conversation
joshdover
added
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
joshdover
added
the
auto-backport
| orgId: schema.conditional( | ||
| schema.siblingRef('enabled'), | ||
| true, | ||
| schema.string({ minLength: 1 }), |
There was a problem hiding this comment.
Are we sure we want to set the min to 1? It seems very lenient to me. Maybe 3 would be better? It gives a few more combinations and permutations.
There was a problem hiding this comment.
I wasn't sure how long these strings could be from FullStory. I doubt we'd ever have one that is only 1 character, but not sure where to put the limit (3, 4, 5?). I figured instead of trying to figure that out to just guard against the most likely misconfiguration which is an empty string.
|
|
||
| describe('xpack.cloud config', () => { | ||
| describe('full_story', () => { | ||
| it('allows orgId when enabled: false', () => { |
There was a problem hiding this comment.
Auto merge got this, will fix on next PR.
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Summary
Currently unused, this adds two new configuration values that will be leveraged in the future for FullStory instrumentation that will only be enabled on Elastic's ESS Cloud service.
xpack.cloud.full_story.enabled(default: false)xpack.cloud.full_story.orgId(default: undefined)We're adding this now so that we Cloud can start supplying these configs without breaking Kibana.